* remove duplicate ()
* remove casts no longer needed
I'm doing these last tasks around isEmpty and isNotEmpty mostly to be sure that nothing has slipped in. Despite I have been very careful, I prefer double check.
+ one typo in ofbizSelenium help (not sure this file is used yet though, seems to be missing some parts which are commented out, for now I guess)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@885093 13f79535-47bb-0310-9956-ffa450edef68
Steps to generate the problem
– Go to https://demo.ofbiz.org/catalog/control/main
– In Right bar at Search Products section Leave Product Id.
– Select "Inventory" in "Product Jump" DropDown.
It is breaking the ProductInventorySummary.ftl and EditProductInventoryItems.ftl code.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884758 13f79535-47bb-0310-9956-ffa450edef68
Lookup added at:
(1) Go to Facility > Shipments, depress Find Shipment(s) link.
(2) Depress any shipment Id (hyperlink) which have Input status.
(3) Depress Items tab, there should be product lookup for Product Id.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884556 13f79535-47bb-0310-9956-ffa450edef68
Moved TabBar Menus from the "body" decorator-section to the "pre-body" decorator section.
This makes better the rendering of themes such as Dropping Crumbs.
Removed several redundant <section><widget> tags also
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883671 13f79535-47bb-0310-9956-ffa450edef68
-- When we are going to associate supplier for any product from catalog, it is showing warning on console.
Thanks Arpit for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883646 13f79535-47bb-0310-9956-ffa450edef68
-- updated patch with use of variable name modifiers in UEL arithmetic, as suggested by Adrian.
Thanks Mridul for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883348 13f79535-47bb-0310-9956-ffa450edef68
Add a new feature in Product Content to add all four images at a time and one can preview those images in larger view on mouse over of particular image.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883280 13f79535-47bb-0310-9956-ffa450edef68
This is the first step to making utilCacheTable concurrent, and
non-blocking. To do so, the constructor has to have no side-effects.
This means it can't modify utilCacheTable itself; this will be moved to
the helper function created above.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883217 13f79535-47bb-0310-9956-ffa450edef68
Having the TabBar menu in the "pre-body" seems to be the right pattern (already present in several screens) that should always be followed.
This change allows a much better rendering of the Dropping Crumbs while having a very little TabBar menu shift in other themes.
All other screens will be changed accordingly.
This commit also fixes OFBIZ-3240
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883020 13f79535-47bb-0310-9956-ffa450edef68
The offending TabBars include-menu tags have been wrapped with a <container style="no-clear">.
I preferred this method instead of what suggested by Adrian in rev.881027 (that consists in changing the menu style) because in principle the menu could be used in other screens where there is no need of this (no multi-column) and also because in this way there is no needs to change the menu every time we change the screen layout.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882725 13f79535-47bb-0310-9956-ffa450edef68
Steps regenerate error:
1) Hit url: https://localhost:8443/ordermgr/control/orderentry
2) Select purchase order with supplier
3) Add product for order
4) Click on the productId from showcart page
it will generate error as following
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen component://order/widget/ordermgr/OrderEntryCatalogScreens.xml#productdetail: java.lang.NullPointerException: Cannot get property 'productStoreId' on null object (Cannot get property 'productStoreId' on null object)
Notes from Mridul:
As Joe has already stated that we need to do few adjustments in the code based on presence of productStoreId. I would vote for:
1. Showing all reviews.
2. Skipping surveys.
The third section, which is the most important one and needs productStoreId is getProductVariantTree service invoked in ProductDetail.groovy (line 232). getProductVariantTree service needs productStoreId to get available inventory. In case of PO's we don't need to check for available inventory at all. Now for being able to use the same code to display product detail page in case of a PO, we will need to make modifications to getProductVariantTree service too, which can be done in two ways:
1. Add a boolean IN attribute checkInventory to service definition, if its true check the available inventory and if false do not.
2. A check on productStoreId in the implementation can serve our purpose too.
I like #1 more as it won't eliminate importance of productStoreId in case of a sales order. Looking forward to suggestions from community to handle this situation.
Thanks Amit for the contribution. Mridul Thanks a lot for providing useful notes for the implementation.
Guys, I appreciate your coordination on this!
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882618 13f79535-47bb-0310-9956-ffa450edef68
Case 1
(a) Go to Facility -> Shipment, click on New Shipment link.
(b) Select "Status Id = Input", "Origin Facility = Web Store Warehouse" & "Shipment type Id = Sales Shipment" then depress Update button.
(c) Now depress Items tab, enter product Id & quantity then depress create button.
(d) Select "New" for Add to Package dropdown and depress Add button.
(e) Now depress Delete button for Item then it will show error message that can be understood by a warehouse manager.
Case 2
(a) Follow #a to #d process in Case 1
(b) Depress Packages tab.
(c) Depress Delete button for Package then it will show error message that can be understood by a warehouse manager.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882555 13f79535-47bb-0310-9956-ffa450edef68
Steps to produce the bug:
1) Place a sales Order,
2) Go through Verify Pick process
3) Go to Packing Screen
4) Enter OrderId and then click on "Weigh Package Only button ."
5) Text boxes to enter weights and dimension of packages should render.
Thanks Divesh for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882068 13f79535-47bb-0310-9956-ffa450edef68
Some translations for the accounting component, and for the CommonUiLabels file
I have also changed some other labels in ProductEntityLabels.xml and ProductUiLabels.xml while I was at it
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@881987 13f79535-47bb-0310-9956-ffa450edef68
Steps for reproduce error
1) Go to partymgr find screen
2) Select customer which have geoPointId [partyId : DemoCustomer ]
3) Update postal address which have geolocation
4) Remove all Contact Purposes and Go Back to profile screen
5) It generate an error due to contactMechPurposeType is undefined
I have extended the use of this patch to 2 other templates
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@881713 13f79535-47bb-0310-9956-ffa450edef68
Layered navigation in an Ecommerce application allows the user to filter the product listing based on categories, features and price ranges. The user can apply multiple filters to the given product listing. He can narrow or expand his search and try different filter combinations so as to find the desired product.
I have implemented Layered Navigation in OFBiz ecommerce with following filters:
1. Sub Categories: This filter is shown whenever there are sub-categories present under the top-level category or current selected category. Count of products within the category is shown against each category, works with multilevel deep category hierarchy. Selecting a sub category will show products within that category and filters will be updated accordingly for the new product list.
2. Features: Feature filters are grouped by Feature Types. Count of products that has the feature associated as standard, selectable or distinguishing is shown against that feature. Current Implementation has feature filters for ProductFeatureType="COLOR".
3. List Price Range: This filter will always show. When applied filters product based on List Price Range. Current implementation is done by listing static price ranges at code level.
The above implementation is completely based on the OOTB Product Search functionality with few additional methods in ProductSearchSession to derive count against different type of filters.
This is collaborative contribution from Mridul Pathak, Jacopo Cappellato & Scott Gray.
Thanks Guys for such a nice contribution - I am sure community will love seeing the existence of "Layered Navigation" in OFBiz trunk.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@835372 13f79535-47bb-0310-9956-ffa450edef68
Following points are covered in this patch:
1) Show associated products for product of type "MARKETING_PKG_AUTO" on order items section of show cart page in order manager application.
2) Marketing packages should only shown backordered when ATP of product which compose Marketing packages product are less than quantity added in cart.
3) Pick sheets should show Products of type Marketing Packages along with the products which compose Marketing Packages.
4) Show link of production run created on order items section of Order detail page while placing order for product of type MARKETING_PKG_AUTO.
5) Product of type Marketing Packages should be shown on Verify Pick Screen along with Products they are composed of.
Thanks Divesh for the contribution - this is very nice addition to the trunk.
I would be more then happy to see comments / concern from - Jacopo? Scott? Anil? or others?
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@834479 13f79535-47bb-0310-9956-ffa450edef68
Following points are covered in this patch:
1) Removed hard-coded product ids for Gift certificates products from GiftCertificates.ftl and added new category type called "GIFT_CARD_CATEGORY" and related demo data, also added groovy script for fetching logic to address this issue.
2) Also handled hard-coded surveyId in AddGiftCertificates.groovy
3) Added user friendly messages if required data is not available .
4) Added missing license header in GiftCertificates.ftl
Thanks Divesh for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@834042 13f79535-47bb-0310-9956-ffa450edef68