Steps regenerate error:
1) Hit url: https://localhost:8443/ordermgr/control/orderentry
2) Select purchase order with supplier
3) Add product for order
4) Click on the productId from showcart page
it will generate error as following
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen component://order/widget/ordermgr/OrderEntryCatalogScreens.xml#productdetail: java.lang.NullPointerException: Cannot get property 'productStoreId' on null object (Cannot get property 'productStoreId' on null object)
Notes from Mridul:
As Joe has already stated that we need to do few adjustments in the code based on presence of productStoreId. I would vote for:
1. Showing all reviews.
2. Skipping surveys.
The third section, which is the most important one and needs productStoreId is getProductVariantTree service invoked in ProductDetail.groovy (line 232). getProductVariantTree service needs productStoreId to get available inventory. In case of PO's we don't need to check for available inventory at all. Now for being able to use the same code to display product detail page in case of a PO, we will need to make modifications to getProductVariantTree service too, which can be done in two ways:
1. Add a boolean IN attribute checkInventory to service definition, if its true check the available inventory and if false do not.
2. A check on productStoreId in the implementation can serve our purpose too.
I like #1 more as it won't eliminate importance of productStoreId in case of a sales order. Looking forward to suggestions from community to handle this situation.
Thanks Amit for the contribution. Mridul Thanks a lot for providing useful notes for the implementation.
Guys, I appreciate your coordination on this!
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882618 13f79535-47bb-0310-9956-ffa450edef68
Create an order from order manager with a GZ-BASKET only
Print the PDF picksheet from the order, use Ctrl+clic (in FF) to return to the order on a new tab : bingo
With this change you don't get an error but an error message, far better for users
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@835421 13f79535-47bb-0310-9956-ffa450edef68
Following points are covered in this patch:
1) Show associated products for product of type "MARKETING_PKG_AUTO" on order items section of show cart page in order manager application.
2) Marketing packages should only shown backordered when ATP of product which compose Marketing packages product are less than quantity added in cart.
3) Pick sheets should show Products of type Marketing Packages along with the products which compose Marketing Packages.
4) Show link of production run created on order items section of Order detail page while placing order for product of type MARKETING_PKG_AUTO.
5) Product of type Marketing Packages should be shown on Verify Pick Screen along with Products they are composed of.
Thanks Divesh for the contribution - this is very nice addition to the trunk.
I would be more then happy to see comments / concern from - Jacopo? Scott? Anil? or others?
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@834479 13f79535-47bb-0310-9956-ffa450edef68
Following points are covered in this patch:
1) Removed hard-coded product ids for Gift certificates products from GiftCertificates.ftl and added new category type called "GIFT_CARD_CATEGORY" and related demo data, also added groovy script for fetching logic to address this issue.
2) Also handled hard-coded surveyId in AddGiftCertificates.groovy
3) Added user friendly messages if required data is not available .
4) Added missing license header in GiftCertificates.ftl
Thanks Divesh for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@834042 13f79535-47bb-0310-9956-ffa450edef68
1) Add additional screen for gift card certificate buying functionality by CSR in Order manager application in add item page
2) Also add feature to fill survey on same page.
3) Also if CSR selects "Create as new order" from Actions block for Gift card products then survey responses will be created automatically for the new order, which will be same as last order.
Thanks Arun / Divesh for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@833323 13f79535-47bb-0310-9956-ffa450edef68
geoAutoCompleter.js currently resides in specialpurpose/ecommerce component. But now it is also used in OrderViewScreen.xml#OrderHeaderView screen. First of all we can't have dependency of ordermgr on ecommerce component. Secondly, if I am developing a custom ecommerce application with mount point /ecommerce, thus overriding specialpurpose/ecommerce webapp, and copying the geoAutoCompleter.js to my custom application (to customize) in a directory structure other than that of specialpurpose/ecommerce, then the JS file is not loaded in OrderHeaderView screen due to change of location. The only reason is the dependency stated above. Hence this change is vital.
While doing this change, all the references to geoAutoCompleter.js will need to be updated too.
Thanks Arpit for the contribution.
Special thanks to Mridul for providing notes for the implementation.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@833026 13f79535-47bb-0310-9956-ffa450edef68
I simply used the same syntax than in other themes (XHTML)
+ added =multiple (XHTML compliant) where needed
+ fixed in product quick admin (wrong syntax multiple=true)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@831801 13f79535-47bb-0310-9956-ffa450edef68
orderHeaderInfo.ftl file used in order entry process.
In this file table used for non tabular data and its and markup of this file not correct.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@829421 13f79535-47bb-0310-9956-ffa450edef68
There is a session issue, actually there is getting ShoppingCart object from session when session is expired then ShoppingCart object will be null and there is no check for this ShoppingCart object and call method of ShoppingCart.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@829412 13f79535-47bb-0310-9956-ffa450edef68
This commit requires ant clean. Also, external libraries that reference GenericDelegator will need to be updated.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821643 13f79535-47bb-0310-9956-ffa450edef68
Removed all occurrences of <div class="screenlet-header"><div class="boxhead"></div></div>
Replaced with the new
<div class="screenlet-title-bar"><div class="h3"></div></div>
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821476 13f79535-47bb-0310-9956-ffa450edef68
Changed from <div class="screenlet-header"> to <div class="screenlet-title-bar">.
Replaced <div class="boxhead"> with <div class="h3">.
This fixes also a white text on white background issue with bluelight theme reported by Matthieu Bollot in the dev ML.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821197 13f79535-47bb-0310-9956-ffa450edef68
When we click on ATP/'Qoh button in purchase order for a particular order item it gives error that facility id is not present.Ideally in case of purchase order it should not be dependent on productStore.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@818715 13f79535-47bb-0310-9956-ffa450edef68
Content of Find Orders page of order component is not coming properly. Not showing content below the "Web Site" select box.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@814531 13f79535-47bb-0310-9956-ffa450edef68
The method is also used to clean the code related to the two existing marketing package types (that have now in common the same parent).
This will make the framework more flexible because you will be able to create a new product subtype and the system will treat them as its parent type; then you can add custom code to treat it in the special way (if needed). This pattern can be extended in other areas of the system, starting from product types (right now it is also applied to marketing packages).
Thanks to Mridul Pathak for the patch - OFBIZ-2902
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@813413 13f79535-47bb-0310-9956-ffa450edef68