Commit Graph
12 Commits
Author SHA1 Message Date
Jacques Le Roux 63ecc059ec Improved: GH Actions and Buildbot Builders are not consistent (INFRA-23076)
Reverts previous commit,
see https://lists.apache.org/thread/80wzf4kclfk5nh2fss56jd6otf7y4n2f
2022-04-18 09:32:48 +02:00
Jacques Le Roux ce84fdb3ca Improved: GH Actions and Buildbot Builders are not consistent (INFRA-23076)
It's now 2 weeks that INFRA-23076 is open, so like 3 weeks that BuildBot is not
working for OFBiz at all.

So far I did not run the integration tests on GH because
* we have it on BuildBot
* it's complicated to show the results

Hopefully BuildBot will soon run the OFBiz builds again. But it does not hurt
to run the integration tests on GH, even w/o the results, because at least it's
easier than running them for each commit locally (takes time) and we can run
them locally once we know there is a problem demonstrated with GH actions.
2022-04-18 09:09:30 +02:00
Jacques Le Roux 243127fc92 Improved: no functional change, removes tests in GH actions
Adding testIntegration in the GH Gradle process does not work.

For a reason I'll not dig in, it ALWAYS fails at:
Cannot find service [indexProductsFromContent] location class
(org.apache.ofbiz.content.search.SearchServices)
2022-01-15 12:14:35 +01:00
Jacques Le Roux 0962230091 Improved: no functional change, add tests to GH actions
Buildbot is stale at the moment and it's better to not rely only on it.
This adds testIntegration to the GH Gradle process
2022-01-15 10:01:41 +01:00
Jacques Le Roux 14f7feda74 Improved: The SARIF file generated by CodeQL for Java classes is too large (OFBIZ-12361)
It still does not work
2021-11-23 13:25:29 +01:00
Jacques Le Roux d5883a855d Improved: Try to reduce the SARIF file used by CodeQL for Java classes (OFBIZ-12361)
According to
https://github.com/github/vscode-codeql/pull/1004
https://github.com/github/vscode-codeql/issues/735
this should now work. Let's try...
2021-11-23 11:32:08 +01:00
Jacques Le Roux 97fa32aa65 Improved: Fix OFBiz specific Javascript security issues reported by GH CodeQL (OFBIZ-12366)
Hopefully this is the right syntax to content
https://github.com/apache/ofbiz-framework/actions/runs/1459245431/workflow
though not on the line signaled. Let's see...
2021-11-14 18:26:02 +01:00
Jacques Le Roux 732f424d3c Improved: Fix OFBiz specific Javascript security issues reported by GH CodeQL (OFBIZ-12366)
I said
<<branches: [ trunk, release* ] is a better syntax because of more restriction
and will work too>>
because this syntax was initially generated by GH. Obviously something is wrong:
https://github.com/apache/ofbiz-framework/actions/runs/1459245431/workflow
Back to '**'
2021-11-14 17:17:44 +01:00
Jacques Le Roux 6d84e02c91 Improved: Fix OFBiz specific Javascript security issues reported by GH CodeQL (OFBIZ-12366)
branches: [ trunk, release* ] is a better syntax because of more restriction and
will work too
2021-11-14 17:05:34 +01:00
Jacques Le Roux 91357bbf0e Improved: modifies GH workflows to run on all branches
I followed this answer: https://github.com/github/codeql-action/issues/462
Too bad, it does not seem to work
https://github.com/apache/ofbiz-framework/actions/workflows/codeql-analysis.yml?query=branch%3Arelease18.12
(OK for trunk: https://github.com/apache/ofbiz-framework/actions/workflows/codeql-analysis.yml?query=)

I try the other syntax, ie '**'
2021-11-14 15:39:02 +01:00
Jacques Le Roux 26ac709078 Improved: modifies GH workflows to run on all branches
Will do the same later on trunk after checking it's OK here (where we don't use
npm to load js libs)
2021-11-14 15:21:37 +01:00
Jacques Le Roux 25e96ca05e Improved: Add same workflows than in trunk
This more a test, easy to revert in case of problems (I see none)
2021-11-14 14:52:31 +01:00