Commit Graph
1603 Commits
Author SHA1 Message Date
Jacques Le Roux d354300e69 Fixed: Logout do not remove autoLogin
(OFBIZ-4959)

I used the only available (and I must say confusing) WebappInfo.getName() when
I needed the webAppName not the WebappInfoName. So this put in a new 
WebappInfo.getMountPoint() and use it in getWebappInfo

Also use LoginWorker.autoLoginSet() in different places where I missed it. In 
other words all autoUserLogin coockies are deleted on login and logout, and
an autoUserLogin cookie is created when going locally from a webapp to another,
with checkExternalLoginKey


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1826938 13f79535-47bb-0310-9956-ffa450edef68
2018-03-16 09:35:06 +00:00
Michael Brohl 7bc137dd35 Improved: Extended UtilFormatOut with new method formatPercentageRate.
(OFBIZ-10199)

Thanks Martin for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1826679 13f79535-47bb-0310-9956-ffa450edef68
2018-03-13 20:16:12 +00:00
Michael Brohl 1885f9a0a0 Improved: Change log level from INFO to VERBOSE for detail logging in
UtilCache.findSizeInByte
(OFBIZ-10200)

Thanks Martin Becker for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1826597 13f79535-47bb-0310-9956-ffa450edef68
2018-03-12 22:08:42 +00:00
Michael Brohl aebec6aafc Fixed: UtilCodec URL decoding breaks values with german umlauts.
(OFBIZ-10275)

Thanks Martin Becker for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1826592 13f79535-47bb-0310-9956-ffa450edef68
2018-03-12 21:43:48 +00:00
Arun Patidar 51f51c1623 Improved:Update regex used for validating credit cards.
(OFBIZ-9761)
Thanks Amit Gadaley for your contribution and Michael Brohl for reviewing patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825216 13f79535-47bb-0310-9956-ffa450edef68
2018-02-24 11:32:18 +00:00
Jacques Le Roux 84bc50b994 Fixed: Logout do not remove autoLogin
(OFBIZ-4959)

Logout method do not disable autoLogin functionality. 
Instead of that it just initializes autoLogin in session and request.

jleroux: this was also needed by OFBIZ-10206 "Security issue in Token Based 
Authentication". 
This creates a keep-autologin-cookie boolean attribute in the webapp element of 
the  ofbiz-component.xml, documented in ofbiz-component.xsd
This attribute is used to get the value from the ofbiz-component.xml files in a
new autoLogoutCleanCookies() LoginWorker method. This method is used not only 
when login out but also when login in. This to be sure that in every cases the 
cookies related to the webapps are removed.
For now only the ecommerce, ecomseo et webpos webapps are keeping and using 
their autologin cookies

Thanks: Roberto Benítez Monje for report and Taher for discussion and suggestion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824803 13f79535-47bb-0310-9956-ffa450edef68
2018-02-19 19:23:36 +00:00
Jacques Le Roux f26b20885a No functional change, removes reference to MD5 in comments. It's not used anymore
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824128 13f79535-47bb-0310-9956-ffa450edef68
2018-02-13 12:51:30 +00:00
Jacques Le Roux 630d993a21 Improved: [DEPRECATION] Replace BigDecimal.ROUND_* by RoundingMode.*
(OFBIZ-9571)

No functional change, just better JavaDoc 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824124 13f79535-47bb-0310-9956-ffa450edef68
2018-02-13 12:45:13 +00:00
Jacques Le Roux 6ce8dd89e3 Improved: [DEPRECATION] Replace BigDecimal.ROUND_* by RoundingMode.*
(OFBIZ-9571)

No functional change, simply better JavaDoc for deprecated 
getBigDecimalRoundingMode() methods

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824104 13f79535-47bb-0310-9956-ffa450edef68
2018-02-13 09:30:34 +00:00
Jacques Le Roux b06570590e Improved: [DEPRECATION] Replace BigDecimal.ROUND_* by RoundingMode.*
(OFBIZ-9571)

UtilNumber class
 Deprecates and replaces both getBigDecimalRoundingMode() by getRoundingMode()
 Deprecates toPercentString()
 Puts a log for a NumberFormatException

Calculate class
 Uses RoundingMode where necessary. No deprecation, this should be only used
 by Minilang

The rest
 Adapts the whole code for that
 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1823931 13f79535-47bb-0310-9956-ffa450edef68
2018-02-12 10:04:29 +00:00
Jacques Le Roux 35679e415b Fixed: UtilNumber.getBigDecimalRoundingMode() returns a wrong value
(OFBIZ-10218)

While working on OFBIZ-9571 I found that getBigDecimalRoundingMode() returns  
DEFAULT_BD_SCALE when the passed value for the file parameter is emtpy. 
This has certainly be C/P from getBigDecimalScale() and never found before.

While at it I refactored a bit getBigDecimalRoundingMode()  and 
getBigDecimalScale() 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1823876 13f79535-47bb-0310-9956-ffa450edef68
2018-02-11 18:51:07 +00:00
Gil Portenseigne fba4f5b235 Implemented : Add new FileUtil methods for zip management (OFBIZ-10188)
Add zipFileStream method that will zip FileStream to a zipped one.
Add unzipFileToFolder method to unzip a given archive to a given Folder.
Add fileUtil groovy test suite that create zip file containing README.md, then unzip it to tmp folder and compare original and unzipped files.
Thanks Jacques for the review.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1823567 13f79535-47bb-0310-9956-ffa450edef68
2018-02-08 15:32:31 +00:00
Nicolas Malin 21fa500df1 Improved: complete previous commit to add security in groovy context (OFBIZ-10196)
add security on groovy junit test
add security on eclipse and intellij groovy dsl definition
Thanks to Dennis Balkir for the suggest

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1823028 13f79535-47bb-0310-9956-ffa450edef68
2018-02-03 14:16:16 +00:00
Jacques Le Roux e45a869e17 Fixed: streaming large content cause out of memory exception.
(OFBIZ-10133)

No functional change in trunk
Slightly improves formatting in streamContent() in trunk. 

Uses the same code in R16, notably for setting
byte[] buffer = new byte[bufferSize];
that guarantee no issues, and using try-with-ressource

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821054 13f79535-47bb-0310-9956-ffa450edef68
2018-01-13 09:37:38 +00:00
Jacques Le Roux 67d62f9ad6 No functional changes.
Replaces close() in finally by try-with-ressource



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821039 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 22:37:25 +00:00
Jacques Le Roux 823cc0bf99 Fixed: streaming large content cause out of memory exception.
(OFBIZ-10133)

When ofbiz streams a large content (eg. video file), get out of memory exception.

To reproduce the issue see the Jira

jleroux: I just removed final for bufferSize, I see no needs for that local
variable

Thanks: Wai for the patch Michael for the discussion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821036 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 21:59:22 +00:00
Jacques Le Roux 7b9792b509 Fixed: Correcting findOne() in OfbizDslDescriptorForEclipse.dsld
(OFBIZ-10159)

The method findOne() which is set in the OfbizDslDescriptorForEclipse.dsld is 
wrong, since there is no implementation for this method, which only has a String 
and a List as parameters. I changed it to the correct method, so it can be used 
within groovy properly, also I put an implementation in the GroovyBaseScriptFile

Thanks: Dennis Balkir

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820966 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 11:24:48 +00:00
Jacques Le Roux 55ba682e2c No functional change, replace tabs by spaces
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820965 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 11:22:31 +00:00
Deepak Dixit fb77a3c477 Improved: Logging: change all System.out/.err/.. println to Debug.log... in the code base (OFBIZ-10045)
Thanks Michael Brohl and Kyra Pritzel-Hentley for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819124 13f79535-47bb-0310-9956-ffa450edef68
2017-12-23 09:08:04 +00:00
Michael Brohl 50c4bba4b2 Improved: Replace all "e.printStackTrace();" by calls to the Debug class.
(OFBIZ-10083)

Thanks Jacques Le Roux for reporting and Kyra Pritzel-Hentley 
for providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818921 13f79535-47bb-0310-9956-ffa450edef68
2017-12-21 12:33:04 +00:00
Michael Brohl 98ee1e4f01 Improved: Fixing defects reported by code analysis tools, package
org.apache.ofbiz.base.util.string.
(OFBIZ-10097)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818677 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 15:19:10 +00:00
Jacques Le Roux 1c1d7dca60 No functional change, puts back this comment after r1818495, it may helps
sometimes, but better be verbose and tested, else it's too much

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818574 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 14:11:26 +00:00
Jacques Le Roux a8d6883644 No functional change, puts back this comment after r1818495, it may helps
sometimes

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818571 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 14:07:58 +00:00
Michael Brohl 4c7f71a9f8 Improved: General refactoring and code improvements, package
org.apache.ofbiz.base.concurrent.
(OFBIZ-9928)

Thanks Dennis Balkir for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818547 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 10:11:40 +00:00
Michael Brohl e489038c59 Improved: General refactoring and code improvements, package
org.apache.ofbiz.base.conversion.
(OFBIZ-9929)

Thanks Dennis Balkir for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818546 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 10:09:55 +00:00
Michael Brohl 7e765af8f9 Improved: General refactoring and code improvements, package
org.apache.ofbiz.base.lang.
(OFBIZ-9931)

Thanks Dennis Balkir for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818543 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 09:41:33 +00:00
Michael Brohl 95b2e68ac7 Improved: General refactoring and code improvements, package
org.apache.ofbiz.base.config.
(OFBIZ-9935)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818539 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 09:23:30 +00:00
Michael Brohl 61ba2c6f5b Improved: General refactoring and code improvements, package
org.apache.ofbiz.base.metrics.
(OFBIZ-9936)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818536 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 09:20:22 +00:00
Nicolas Malin 06dda4ae17 Fixed: Massive stacktraces in JuelConnector.
Added a constraint to verbose logging to avoid logging too much.

Complete the revision 1818498

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818510 13f79535-47bb-0310-9956-ffa450edef68
2017-12-17 20:01:06 +00:00
Michael Brohl a9cd441fc3 Improved: General refactoring and code improvements, package
org.apache.ofbiz.base.test.
(OFBIZ-9938)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818505 13f79535-47bb-0310-9956-ffa450edef68
2017-12-17 19:00:31 +00:00
Michael Brohl 90b6706b2c Improved: General refactoring and code improvements, package
org.apache.ofbiz.base.util.cache.
(OFBIZ-9939)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818504 13f79535-47bb-0310-9956-ffa450edef68
2017-12-17 18:57:17 +00:00
Michael Brohl 4ec7fb0588 Improved: General refactoring and code improvements, package
org.apache.ofbiz.base.util.cache.test.
(OFBIZ-9940)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818503 13f79535-47bb-0310-9956-ffa450edef68
2017-12-17 18:55:31 +00:00
Michael Brohl 80a852fcdf Improved: General refactoring and code improvements, package
org.apache.ofbiz.base.util.template.
(OFBIZ-9941)

Thanks Dennis Balkir for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818502 13f79535-47bb-0310-9956-ffa450edef68
2017-12-17 18:54:10 +00:00
Michael Brohl 57f1e05e77 Improved: General refactoring and code improvements, package
org.apache.ofbiz.base.crypto.
(OFBIZ-9942)

Thanks Dennis Balkir for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818501 13f79535-47bb-0310-9956-ffa450edef68
2017-12-17 18:51:18 +00:00
Michael Brohl d3580da466 Fixed: Massive stacktraces in JuelConnector.
Added a constraint to verbose logging to avoid logging too much.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818498 13f79535-47bb-0310-9956-ffa450edef68
2017-12-17 18:08:53 +00:00
Michael Brohl 960394e6c2 Improved: General refactoring and code improvements, package
org.apache.ofbiz.base.util.
(OFBIZ-9944)

Thanks Dennis Balkir for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818495 13f79535-47bb-0310-9956-ffa450edef68
2017-12-17 16:57:56 +00:00
Jacques Le Roux d1bdee2c6c Improved: Always check if debug verbose is on when using Debug.logVerbose()
(OFBIZ-10052)

This completes the work done so far by removing double check in cases not using 
brackets, like
if (Debug.verboseOn())
  if (Debug.verboseOn()) Debug.logVerbose()

Thanks: Michael for reporting this case I missed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818445 13f79535-47bb-0310-9956-ffa450edef68
2017-12-16 19:00:19 +00:00
Jacques Le Roux 4928bf3ae5 Improved: Always check if debug verbose is on when using Debug.logVerbose()
(OFBIZ-10052)

This completes r1818075, there were still few cases, a last regexp search is 
never too much :)

Found 4 other loops with Strings concatenation, but who cares, it's only 
verbose logging...

There should not be anymore...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818077 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 22:37:16 +00:00
Jacques Le Roux 735f946b83 Improved: Always check if debug verbose is on when using Debug.logVerbose()
(OFBIZ-10052)

This completes r1818020, there were still few cases, a last review is never too
much

In PriceServices, I spotted
  for (GenericValue orderItemPriceInfo: orderItemPriceInfos) {
      if (Debug.verboseOn()) Debug.logVerbose(" --- " + orderItemPriceInfo
but it's OK with me, this should be rarely used, so not a perf issue


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818075 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 22:24:25 +00:00
Jacques Le Roux 40e8be83df Improved: Always check if debug verbose is on when using Debug.logVerbose()
(OFBIZ-10052)

This completes r1818010, there were much more cases.
Also few tabs automatically replaced by spaces

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818020 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 14:11:38 +00:00
Michael Brohl e0a296741b Improved: removed unused imports.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818008 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 13:04:27 +00:00
Michael Brohl bb3fff1b21 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.base.util.string.
(OFBIZ-9700)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818007 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 13:03:03 +00:00
Jacques Le Roux e0d2057456 Improved: Always check if debug verbose is on when using Debug.logVerbose()
(OFBIZ-10052)

We discussed on this point: http://markmail.org/message/mplvusuqn7oshl4v 
and we agreed about better doing a check when using Debug.logVerbose().

I checked there are 300+ cases like that. Since it's an easy S/R 
This implements it

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818005 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 12:43:05 +00:00
Michael Brohl 2d13c73a02 Reverted: Fixing defects reported by FindBugs, package
org.apache.ofbiz.base.util.string.
(OFBIZ-9700)

There is an Exception being thrown during the tests, reverting and
investigating further.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817963 13f79535-47bb-0310-9956-ffa450edef68
2017-12-12 22:32:00 +00:00
Michael Brohl 216226db9b Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.base.util.string.
(OFBIZ-9700)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817935 13f79535-47bb-0310-9956-ffa450edef68
2017-12-12 16:41:06 +00:00
Michael Brohl bae1848cd8 Improved: General refactoring and code improvements, package
org.apache.ofbiz.base.component.
(OFBIZ-9872)

Thanks Dennis Balkir for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817883 13f79535-47bb-0310-9956-ffa450edef68
2017-12-12 06:26:29 +00:00
Michael Brohl 3c8804772d Reverted: General refactoring and code improvements, package
org.apache.ofbiz.base.component.
(OFBIZ-9872)

The patches were modified to remove Debug.is[Loglevel]On()
conditions. It is better to keep them for better runtime performance.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817882 13f79535-47bb-0310-9956-ffa450edef68
2017-12-12 06:24:37 +00:00
Michael Brohl 4f48862e29 Improved: General refactoring and code improvements, package
org.apache.ofbiz.base.component.
(OFBIZ-9872)

The patches were modified to remove unnecessary Debug.is[Loglevel]On()
conditions, see OFBIZ-10049.

Thanks Dennis Balkir for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817750 13f79535-47bb-0310-9956-ffa450edef68
2017-12-11 07:54:13 +00:00
Michael Brohl ca83629678 Improved: General refactoring and code improvements, package
org.apache.ofbiz.base.container.
(OFBIZ-9861)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817744 13f79535-47bb-0310-9956-ffa450edef68
2017-12-11 06:41:08 +00:00
Michael Brohl 7cc0b229a6 Improved: General refactoring and code improvements, package
org.apache.ofbiz.base.util.collections.
(OFBIZ-9860)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817743 13f79535-47bb-0310-9956-ffa450edef68
2017-12-11 06:34:02 +00:00