From f421e7ced4ea77a40f625b5912dbd4fbc20c7045 Mon Sep 17 00:00:00 2001 From: Jacques Le Roux Date: Mon, 2 Sep 2019 07:34:03 +0000 Subject: [PATCH] "Applied fix from trunk for revision: 1866259" ------------------------------------------------------------------------ r1866259 | jleroux | 2019-09-02 09:32:48 +0200 (lun. 02 sept. 2019) | 10 lignes Fixed: NotSerializableException after uploading images to an order (OFBIZ-11123) In a lot of services we use the ByteBuffer object to upload files. When a such service is used with the redirect-parameter in a controller the ByteBuffer needs to be serialized. Unfortunately ByteBuffer (in our case its subclass HeapByteBuffer) is not serializable. So that can't work. Fortunately no redirect-parameter concerns uploadedFile so we can safely remove it from reqAttrMap in RequestHandler ------------------------------------------------------------------------ git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1866261 13f79535-47bb-0310-9956-ffa450edef68 --- .../java/org/apache/ofbiz/webapp/control/RequestHandler.java | 1 + 1 file changed, 1 insertion(+) diff --git a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java index 40344a305c..2e4267872a 100644 --- a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java +++ b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java @@ -818,6 +818,7 @@ public class RequestHandler { } if (reqAttrMap.size() > 0) { reqAttrMap.remove("_REQUEST_HANDLER_"); // RequestHandler is not serializable and must be removed first. See http://issues.apache.org/jira/browse/OFBIZ-750 + reqAttrMap.remove("uploadedFile"); // uploadedFileis not serializable (it's a HeapByteBuffer) and must be removed first. See http://issues.apache.org/jira/browse/OFBIZ-11123 byte[] reqAttrMapBytes = UtilObject.getBytes(reqAttrMap); if (reqAttrMapBytes != null) { req.getSession().setAttribute("_REQ_ATTR_MAP_", StringUtil.toHexString(reqAttrMapBytes));