diff --git a/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceServices.java b/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceServices.java index 6c0dc2fbad..24597e8dad 100644 --- a/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceServices.java +++ b/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceServices.java @@ -2955,7 +2955,7 @@ public class InvoiceServices { } } } - successMessage.concat(UtilProperties.getMessage(resource, "AccountingSuccessFull",locale)); + successMessage = successMessage.concat(UtilProperties.getMessage(resource, "AccountingSuccessFull",locale)); return results; } diff --git a/applications/content/src/ControlApplet.java b/applications/content/src/ControlApplet.java index e6e1262030..307c416756 100644 --- a/applications/content/src/ControlApplet.java +++ b/applications/content/src/ControlApplet.java @@ -193,7 +193,7 @@ public class ControlApplet extends Applet implements Runnable { String responseStr = in.readLine(); in.close(); if (responseStr != null) - responseStr.trim(); + responseStr = responseStr.trim(); if (debug != null && debug.equalsIgnoreCase("true")) System.out.println("Receive response: " + responseStr); return responseStr; diff --git a/applications/content/src/org/ofbiz/content/content/ContentWorker.java b/applications/content/src/org/ofbiz/content/content/ContentWorker.java index ad9cde80cf..18f023427b 100644 --- a/applications/content/src/org/ofbiz/content/content/ContentWorker.java +++ b/applications/content/src/org/ofbiz/content/content/ContentWorker.java @@ -695,7 +695,7 @@ public class ContentWorker implements org.ofbiz.widget.ContentWorkerInterface { List contentList = new ArrayList(); String contentIdName = "contentId"; if (linkDir != null && linkDir.equalsIgnoreCase("TO")) { - contentIdName.concat("To"); + contentIdName = contentIdName.concat("To"); } GenericValue assoc = null; GenericValue content = null; @@ -729,8 +729,8 @@ public class ContentWorker implements org.ofbiz.widget.ContentWorkerInterface { String contentIdName = "contentId"; String contentAssocViewName = "contentAssocView"; if (linkDir != null && linkDir.equalsIgnoreCase("TO")) { - contentIdName.concat("To"); - contentAssocViewName.concat("To"); + contentIdName = contentIdName.concat("To"); + contentAssocViewName = contentAssocViewName.concat("To"); } EntityExpr expr = new EntityExpr(contentIdName, EntityOperator.EQUALS, origContentId); exprListAnd.add(expr); diff --git a/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartItem.java b/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartItem.java index 8d89abcd88..ef99563b45 100644 --- a/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartItem.java +++ b/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartItem.java @@ -652,7 +652,7 @@ public class ShoppingCartItem implements java.io.Serializable { } /** Creates new ShoppingCartItem object. */ - protected ShoppingCartItem(GenericValue product, Map additionalProductFeatureAndAppls, Map attributes, String prodCatalogId, ProductConfigWrapper configWrapper, Locale locale, String itemType, ShoppingCart.ShoppingCartItemGroup itemGroupi, GenericValue parentProduct) { + protected ShoppingCartItem(GenericValue product, Map additionalProductFeatureAndAppls, Map attributes, String prodCatalogId, ProductConfigWrapper configWrapper, Locale locale, String itemType, ShoppingCart.ShoppingCartItemGroup itemGroup, GenericValue parentProduct) { this._product = product; this.productId = _product.getString("productId"); this._parentProduct = parentProduct; diff --git a/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java b/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java index 88c867825e..20c2e3bca9 100644 --- a/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java +++ b/specialpurpose/pos/src/org/ofbiz/pos/PosTransaction.java @@ -313,7 +313,7 @@ public class PosTransaction implements Serializable { Debug.logError(e, module); } String nameOnCard = cc.getString("firstNameOnCard") + " " + cc.getString("lastNameOnCard"); - nameOnCard.trim(); + nameOnCard = nameOnCard.trim(); payInfo.put("nameOnCard", nameOnCard); String cardNum = cc.getString("cardNumber");