From c91c4f856db5c57cb5fd45126ea2f9c0cc5d8ba3 Mon Sep 17 00:00:00 2001 From: Jacques Le Roux Date: Fri, 25 Dec 2020 16:09:43 +0100 Subject: [PATCH] Fixed: Issue in creating promotion action (OFBIZ-11168) The issue reported there was fixed with OFBIZ-11058. But there was still an issue in logI reported in a comment. The problem was that <#assign productPromoActionCurEnum = productPromoAction.getRelatedOne("ActionEnumeration", true)> was used in 2 places where it should not have been because it returned a null value that can't be handled by OFBiz. Better use <#assign productPromoActionCustomMethod = productPromoAction.getRelatedOne("CustomMethod", true)> and productPromoAction.getRelatedOne("ActionEnumeration", true))?? The repercussion was that the description was not used but the Id and the log was showing an error. --- .../template/promo/EditProductPromoRules.ftl | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/applications/product/template/promo/EditProductPromoRules.ftl b/applications/product/template/promo/EditProductPromoRules.ftl index 757f884bc1..facd7f33f0 100644 --- a/applications/product/template/promo/EditProductPromoRules.ftl +++ b/applications/product/template/promo/EditProductPromoRules.ftl @@ -291,8 +291,14 @@ under the License. <#if (productPromoAction.useCartQuantity)??> - <#assign productPromoActionCurEnum = productPromoAction.getRelatedOne("ActionEnumeration", true)> <#else> @@ -392,7 +397,7 @@ under the License.
${(actionProduct.internalName)!} [${actionProductPromoProduct.productId}] - ${(actionApplEnumeration.get("description",locale))?default(actionProductPromoProduct.productPromoApplEnumId)} -
+