From 6e5a614b692f00a7f98cd208cbf0a7e4e136fefb Mon Sep 17 00:00:00 2001 From: Jacques Le Roux Date: Sat, 18 Jul 2020 12:00:29 +0200 Subject: [PATCH] Improved: Reflected XSS in content component (OFBIZ-11840) Fixes a Reflected XSS vulnerability in content component Harshit Shukla reported it to the OFBiz security team: https://demo-stable.ofbiz.apache.org/content/control/stream?contentId="> It's a post-auth vulnerability so we did not ask for a CVE. Thanks: Harshit Shukla harshit.shukz@gmail.com --- .../java/org/apache/ofbiz/content/data/DataEvents.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/applications/content/src/main/java/org/apache/ofbiz/content/data/DataEvents.java b/applications/content/src/main/java/org/apache/ofbiz/content/data/DataEvents.java index 8278b02fd5..9d6b80c0aa 100644 --- a/applications/content/src/main/java/org/apache/ofbiz/content/data/DataEvents.java +++ b/applications/content/src/main/java/org/apache/ofbiz/content/data/DataEvents.java @@ -82,6 +82,13 @@ public class DataEvents { // get the permission service required for streaming data; default is always the genericContentPermission String permissionService = EntityUtilProperties.getPropertyValue("content", "stream.permission.service", "genericContentPermission", delegator); + // This is counterintuitive but it works, for OFBIZ-11840 + // It could be improved by checking for possible events associated with svg + // As listed at https://portswigger.net/web-security/cross-site-scripting/cheat-sheet + if (contentId.contains("