From 6380d64dfd2b0403bbf24da36f01712f36aa0b07 Mon Sep 17 00:00:00 2001 From: Scott Gray Date: Tue, 14 Oct 2008 20:48:32 +0000 Subject: [PATCH] Changed the cross domain session valve to skip rewriting the session cookie if the domain is an IP address Thanks to Adrian Crum for reporting the issue git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@704678 13f79535-47bb-0310-9956-ffa450edef68 --- .../container/CrossSubdomainSessionValve.java | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/framework/catalina/src/org/ofbiz/catalina/container/CrossSubdomainSessionValve.java b/framework/catalina/src/org/ofbiz/catalina/container/CrossSubdomainSessionValve.java index 68d8fcf315..c2fb092fee 100644 --- a/framework/catalina/src/org/ofbiz/catalina/container/CrossSubdomainSessionValve.java +++ b/framework/catalina/src/org/ofbiz/catalina/container/CrossSubdomainSessionValve.java @@ -52,7 +52,18 @@ public class CrossSubdomainSessionValve extends ValveBase { if (UtilValidate.isEmpty(cookieDomain)) { String serverName = request.getServerName(); String[] domainArray = serverName.split("\\."); - if (domainArray.length > 2) { + // check that the domain isn't an IP address + if (domainArray.length == 4) { + boolean isIpAddress = true; + for (String domainSection : domainArray) { + if (!UtilValidate.isIntegerInRange(domainSection, 0, 255)) { + isIpAddress = false; + break; + } + } + if (isIpAddress) return; + } + if (domainArray.length > 2 && UtilValidate.isAlphabetic(domainArray[domainArray.length - 1])) { cookieDomain = "." + domainArray[domainArray.length - 2] + "." + domainArray[domainArray.length - 1]; } }